-
Notifications
You must be signed in to change notification settings - Fork 167
Open
Description
I've encountered several issues when going over the first few chapters of your book.
- There are no instructions on how to compile
.cppfiles (the book mentionsclangbutclang++needs to be used instead). - Many code assembly blocks start with
```textinstead of```asm. -
section_1/hello_world/v3.cpp->section_1/hello_world/v3.c. -
section_1/ifdoesn't have a macOS version (section_1/hello_worldintroduces macros that here are not used). -
v6.SusesPUSH_PandPUSH_R, which are not explained. Maybe for pushing a Pair of registers or a single Register to the stack. -
v6.Smovessptox29for no clear reason. -
v6.Suses1:and2:labels and2fand1b, which are only explained in a later chapter. -
hello_world/README.mdsays thatfor (; argv; argv++)has the "added benefit that the increment of theargvpointer is not a side effect" which is not true. After the loop,argvvalue is no longer the initial one. -
xzrinmov x0, xzrinsection_1/hello_world/v5.shas never been defined (and it's less readable thanmov x0, #0). -
section_1/structs/alignment.mdtalks about a hex dump, but there are no instructions about how to do such a thing. So, it's impossible to follow along what the book is explaining. - I don't know how to compile
section_1/structs/test01.cfor inspecting the binary.
I didn't want to create a separate issue for each item.
I hope you do appreciate this kind of feedback.
P.S. I've pushed some of these changes to my fork of your repo.
Metadata
Metadata
Assignees
Labels
No labels