Fix: Using safeParser to parse Insomnia git yaml files #9425
+84
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwangsmv
requested review from
CurryYangxx,
gatzjames,
pavkout and
yaoweiprc
and removed request for
a team
cwangsmv
force-pushed
the
fix/using-safeParser-for-git-sync
branch
from
6e50887 to
dc05823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently we're using
InsomniaFileSchema.parseto parse git yaml files directly. Whenever it meets malformed yaml files or yaml file that is not supported for current version, it will throw error and the application will crash.Changes
InsomniaFileSchema.safeParserto parse yaml files instead.file.typeis not recognized rather than fall back to mock server workspace by defaultINS-1763