Skip to content

feat(chart-scale-set): Add support for custom dind image and imagePullPolicy #4333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djetelina wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(chart-scale-set): Add support for custom dind image and imagePullPolicy #4333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions charts/gha-runner-scale-set/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ app.kubernetes.io/instance: {{ include "gha-runner-scale-set.scale-set-name" . }
{{- range $i, $val := .Values.template.spec.containers }}
{{- if eq $val.name "runner" }}
image: {{ $val.image }}
imagePullPolicy: {{ $val.imagePullPolicy }}
command: ["cp"]
args: ["-r", "/home/runner/externals/.", "/home/runner/tmpDir/"]
volumeMounts:
Expand All @@ -96,7 +97,11 @@ volumeMounts:
{{- end }}

{{- define "gha-runner-scale-set.dind-container" -}}
image: docker:dind
{{- $root := . -}}
{{- range $i, $val := .Values.template.spec.dindContainers }}
{{- if eq $val.name "dind" }}
image: {{ $val.image }}
imagePullPolicy: {{ $val.imagePullPolicy }}
args:
- dockerd
- --host=unix:///var/run/docker.sock
Expand All @@ -106,7 +111,7 @@ env:
value: "123"
securityContext:
privileged: true
{{- if (ge (.Capabilities.KubeVersion.Minor | int) 29) }}
{{- if (ge ($root.Capabilities.KubeVersion.Minor | int) 29) }}
restartPolicy: Always
startupProbe:
exec:
Expand All @@ -124,6 +129,8 @@ volumeMounts:
mountPath: /var/run
- name: dind-externals
mountPath: /home/runner/externals
{{- end }}
{{- end }}
{{- end }}

{{- define "gha-runner-scale-set.dind-volume" -}}
Expand Down
5 changes: 5 additions & 0 deletions charts/gha-runner-scale-set/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,12 @@ template:
containers:
- name: runner
image: ghcr.io/actions/actions-runner:latest
imagePullPolicy: Always
command: ["/home/runner/run.sh"]
dindContainers:
- name: dind
image: docker:dind
imagePullPolicy: Always
## Optional controller service account that needs to have required Role and RoleBinding
## to operate this gha-runner-scale-set installation.
## The helm chart will try to find the controller deployment and its service account at installation time.
Expand Down