Skip to content

Conversation

@salmanmkc
Copy link
Contributor

@salmanmkc salmanmkc commented Dec 9, 2025

This pull request documents the release of version 5.0.0 for the @actions/cache package, highlighting several dependency updates, a dependency removal, and node 24 support.

@salmanmkc salmanmkc requested a review from a team as a code owner December 9, 2025 16:10
Copilot AI review requested due to automatic review settings December 9, 2025 16:10
@salmanmkc salmanmkc force-pushed the prepare-cache-release-v5.0.0 branch from 40cee30 to b046462 Compare December 9, 2025 16:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the @actions/cache package for its v5.0.0 release by upgrading all @actions dependencies to their latest major versions, ensuring compatibility with Node.js 24 and addressing security vulnerabilities.

Key Changes:

  • Major version bumps for all @actions dependencies (@actions/core, @actions/exec, @actions/glob, @actions/http-client, and @actions/io)
  • Updated documentation to reference v5.0.0 instead of v4.0.0
  • Node.js 24 support and node-fetch override for security

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
packages/cache/package.json Updated all @actions dependencies from v1.x/v0.x/v2.x to their latest major versions (v2.x/v0.5.x/v3.x)
packages/cache/package-lock.json Synchronized lockfile with updated dependencies, including proper nested dependency resolution for packages with conflicting version requirements
packages/cache/RELEASES.md Added v5.0.0 release notes documenting the dependency upgrades and new Node.js 24 support
packages/cache/README.md Updated version references from 4.0.0 to 5.0.0 in the important changes section
Files not reviewed (1)
  • packages/cache/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

GhadimiR
GhadimiR previously approved these changes Dec 10, 2025
- Removed `@azure/ms-rest-js` dependency to fix Node.js 24+ punycode deprecation warning.
  - The `TransferProgressEvent` type is now imported from `@azure/core-rest-pipeline`.
- Updated `package.json` to reflect the new dependency.
- Updated tests to import `TransferProgressEvent` from the new package.
- Updated `package-lock.json` to remove `@azure/ms-rest-js` and include `@azure/core-rest-pipeline`.
- Bumped versions of several dependencies including `@azure/storage-blob` and `@azure/storage-common`.
@jsoref
Copy link
Contributor

jsoref commented Dec 10, 2025

https://www.npmjs.com/package/undici has a 7.x, but there are still things pulling in 5.x:

"undici": "^5.25.4"

@salmanmkc
Copy link
Contributor Author

salmanmkc commented Dec 10, 2025

https://www.npmjs.com/package/undici has a 7.x, but there are still things pulling in 5.x:

"undici": "^5.25.4"

This can be a follow up. It requires bumping another 3 packages which will delay this process even further. So far npm audit seems to be fine how it is, and we can look into bumping this later.

@jsoref
Copy link
Contributor

jsoref commented Dec 10, 2025

Do note that https://www.npmjs.com/package/undici#user-content-long-term-support says:

Undici aligns with the Node.js LTS schedule. The following table shows the supported versions:

Undici Version Bundled in Node.js Node.js Versions Supported End of Life
5.x 18.x ≥14.0 (tested: 14, 16, 18) 2024-04-30
... ... ... ...
7.x 24.x ≥20.18.1 (tested: 20, 22, 24) 2027-04-30

@jsoref
Copy link
Contributor

jsoref commented Dec 10, 2025

Which is kinda important, since it's still included:

"@azure/core-http": "^3.0.5",

And it triggers:

npm warn deprecated @azure/core-http@3.0.5: This package is no longer supported. Please refer to https://github.com/Azure/azure-sdk-for-js/blob/490ce4dfc5b98ba290dee3b33a6d0876c5f138e2/sdk/core/README.md

@salmanmkc
Copy link
Contributor Author

Do note that https://www.npmjs.com/package/undici#user-content-long-term-support says:

Undici aligns with the Node.js LTS schedule. The following table shows the supported versions:

Undici Version
Bundled in Node.js
Node.js Versions Supported
End of Life

5.x
18.x
≥14.0 (tested: 14, 16, 18)
2024-04-30

...
...
...
...

7.x
24.x
≥20.18.1 (tested: 20, 22, 24)
2027-04-30

Thanks, that's useful to know

Which is kinda important, since it's still included:

"@azure/core-http": "^3.0.5",

And it triggers:

npm warn deprecated @azure/core-http@3.0.5: This package is no longer supported. Please refer to https://github.com/Azure/azure-sdk-for-js/blob/490ce4dfc5b98ba290dee3b33a6d0876c5f138e2/sdk/core/README.md

As per core-http, will keep that in mind when upgrading artifact, thanks for pointing that out. Will keep it out of this PR though since this is for cache.

@salmanmkc
Copy link
Contributor Author

salmanmkc commented Dec 10, 2025

Do note that https://www.npmjs.com/package/undici#user-content-long-term-support says:

Undici aligns with the Node.js LTS schedule. The following table shows the supported versions:

Undici Version
Bundled in Node.js
Node.js Versions Supported
End of Life

5.x
18.x
≥14.0 (tested: 14, 16, 18)
2024-04-30

...
...
...
...

7.x
24.x
≥20.18.1 (tested: 20, 22, 24)
2027-04-30

I've made this PR, releases will need to follow at some point. #2205

Seems a bit more involved, I will work on trying to make it compatible.

@salmanmkc salmanmkc requested a review from a team as a code owner December 11, 2025 14:35
@salmanmkc salmanmkc force-pushed the prepare-cache-release-v5.0.0 branch from abc0556 to cc6abe3 Compare December 11, 2025 14:43
@salmanmkc salmanmkc requested a review from a team December 11, 2025 15:25
@salmanmkc salmanmkc merged commit e74405f into main Dec 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants