Skip to content

Conversation

@karcherm
Copy link
Contributor

@karcherm karcherm commented Dec 12, 2025

The task is initially "active", and should be considered "completed" when the bundle generation result is displayed, even if the generation failed. The task should only switch back to "active" when changes are detected, not on any arbitrary output by ng watch.

Fixes #32111

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #32111

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

google-cla bot commented Dec 12, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hybrist hybrist added action: review The PR is still awaiting reviews from at least one requested reviewer area: @schematics/angular type: bug/fix target: patch This PR is targeted for the next patch release labels Dec 12, 2025
@hybrist
Copy link
Contributor

hybrist commented Dec 12, 2025

@karcherm Thanks for sending this! I think the change itself looks good but the commit message is missing the : after the closing parenthesis. Can you amend and force push with an updated commit message?

…t/end detection

The task is initially "active", and should be considered "completed" when the bundle generation
result is displayed, even if the generation failed. The task should only switch back to "active"
when changes are detected, not on any arbitrary output by `ng watch`.

This change enables proper handling of re-attaching the debugger while the background task is
already running.

Fixes angular#32111
@karcherm
Copy link
Contributor Author

@karcherm Thanks for sending this! I think the change itself looks good but the commit message is missing the : after the closing parenthesis. Can you amend and force push with an updated commit message?

Done

@hybrist hybrist added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 13, 2025
@hybrist hybrist merged commit 52ace04 into angular:main Dec 13, 2025
35 checks passed
@hybrist
Copy link
Contributor

hybrist commented Dec 13, 2025

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

start task always displayed as "running" in VS Code

2 participants