Skip to content

Conversation

@hougantc-nvda
Copy link

@hougantc-nvda hougantc-nvda commented Dec 4, 2025

  • Support custom loader properties via lovr.conf initproperties table
  • Fix null terminator buffer overflow in extension string allocation
  • LOVR_BUILD_WITH_SYMBOLS now exports all symbols on Windows
  • Add NVIDIA to contributors

- Support custom loader properties via lovr.conf initproperties table
- Fix null terminator buffer overflow in extension string allocation
- LOVR_BUILD_WITH_SYMBOLS now exports all symbols on Windows
- Add NVIDIA to contributors
@hougantc-nvda hougantc-nvda force-pushed the nv-modifications-on-dev branch from 37c289b to b48e63f Compare December 5, 2025 02:29
@hougantc-nvda hougantc-nvda changed the title Add plugin extensibility and OpenXR handle exports Add OpenXR loader init properties support Dec 5, 2025
#endif

// Initialize loader with properties (for custom runtime paths, etc.)
#if defined(__linux__) || defined(__APPLE__) || defined(_WIN32)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you have other code for Android so I targeted xrInitializeLoaderKHR to desktop platforms.

@bjornbytes
Copy link
Owner

Given the xrInitializeLoaderKHR doesn't really depend on any of lovr's internal OpenXR stuff, is there a reason the loader properties need to be plumbed through lovr? Could you do something like require('myplugin').initLoader({ properties = {} }) in conf.lua and set up the loader before booting the rest of lovr? These initialization properties feel a bit too low-level / esoteric compared to the usual configuration lovr exposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants