Add more assertions to field name length limit tests #139404
Open
+28
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-powers
added
>test
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
reviewed
Dec 12, 2025
| body: | ||
| settings: | ||
| index: | ||
| auto_expand_replicas: '0-1' |
Member
There was a problem hiding this comment.
would setting replicas to zero give the same insight the next time this test fail?
Contributor
Author
There was a problem hiding this comment.
Good point. I suspect the issue might be related to the fact that this test is usually run against a single node and so the replica is unassigned, but in the SmokeTestMultiNodeClientYamlTestSuiteIT there are multiple nodes and the replica is assigned.
Let's see if removing the replica entirely causes the failures to stop occurring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more assertions so that if it fails again in CI, we get more information.
Fixes #138471
Fixes #138768
Fixes #139300