C#: Connect shared Guards to SSA BarrierGuards. #21018
Merged
+20
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
dca is uneventful. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the SSA barrier guard implementation to support guard wrappers and enable testing on GuardValue objects instead of just booleans. The changes integrate more closely with the shared Guards module infrastructure.
- Introduces
ValidationWrapperusage inBarrierGuardto support guard wrappers - Replaces custom
GuardandGuardValueimplementations with direct use ofGuards::GuardandGuards::GuardValue - Simplifies guard control block predicates by delegating to standard Guards module methods
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hvitved
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for guard wrappers and BarrierGuards that test on GuardValues instead of just booleans.