Fix a double free of the implicit variable #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A raw pointer to the implicit variable is returned from `interpretExprNode`. Most expressions free ValueObjects returned from `interpretExprNode` after using the value. This resulted in the implicit variable being deleted after its first use. When the scope object is cleaned up, implicit variable is deleted again, resulting in a double free. There are two simple solutions to this: 1. Set the implicit variable pointer in the scope to NULL after it's used in the expression. 2. Use a copy of the implicit variable in the expression. I chose the latter because it seemed simpler and didn't destroy any data. Hopefully it doesn't lead to memory leaks. The one interpret statement that doesn't delete expression values after use is `interpretSystemCommandExprNode`. Aside from that function, this should be a safe change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #47
A raw pointer to the implicit variable is returned from
interpretExprNode.Most expressions free ValueObjects returned from
interpretExprNodeafterusing the value. This resulted in the implicit variable being deleted after
its first use.
When the scope object is cleaned up, implicit variable is deleted again,
resulting in a double free. There are two simple solutions to this:
expression.
I chose the latter because it seemed simpler and didn't destroy any data.
A test has also been added to catch regressions, though it only tests the
addition operator.