[IMP] General: User devices #15691
Open
[IMP] General: User devices #15691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
larm-odoo
force-pushed
the
18.0-employees-new-method-equipment-larm
branch
from
51e1468 to
655dcbf
Compare
Contributor
Author
|
Hi @jero-odoo - I made this PR originally thinking it was information for the Employees app- it is not! Since I had already started, I figured out where the information should be located and thought this was an appropriate place for it. If you have any suggestions or think it should be someplace else, let me know. Thanks! |
jero-odoo
approved these changes
Dec 12, 2025
Contributor
jero-odoo
left a comment
jero-odoo
left a comment
There was a problem hiding this comment.
Just the one quick note @larm-odoo ! Looks good to me
larm-odoo
force-pushed
the
18.0-employees-new-method-equipment-larm
branch
from
655dcbf to
e435f95
Compare
Contributor
Author
|
Hi @Felicious - this is ready for a final/tech review. Thanks! |
Felicious
approved these changes
Dec 13, 2025
Contributor
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
gj @larm-odoo ! Approved with an optional rewording suggestion
@robodoo delegate+
Comment on lines
+89
to
+91
| If a device is legitimate and should be stored in the database, click :guilabel:`Save`. If the | ||
| device should be removed from the list of devices, but is *not* a security threat (is a legitimate | ||
| login), click :guilabel:`Delete`. |
Contributor
There was a problem hiding this comment.
I feel like there's a more concise way to say this?
(optional!)
Suggested change
| If a device is legitimate and should be stored in the database, click :guilabel:`Save`. If the | |
| device should be removed from the list of devices, but is *not* a security threat (is a legitimate | |
| login), click :guilabel:`Delete`. | |
| If a device is legitimate and should be retained, click :guilabel:`Save`. | |
| If the device is legitimate but should **not** be retained, and does not pose a security risk, click click :guilabel:`Delete`. |
New line because they're different thoughts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was requested to add info on user devices on this task card.