Skip to content

Conversation

@rquidute
Copy link
Contributor

Fix unit tests not working

Related Issue

project-chip/certification-tool#828

Testing

CLI Unit tests running successfully
Screenshot 2025-12-15 at 14 55 05

@rquidute rquidute self-assigned this Dec 15, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rquidute, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on rectifying issues that prevented the CLI unit tests from executing correctly. It involves a significant overhaul of the Python testing dependency stack, establishing a comprehensive Pytest and Coverage configuration, and refining the display of test execution results within the command-line interface. These changes collectively aim to restore the functionality and reliability of the CLI's test suite.

Highlights

  • Dependency Updates: Numerous development dependencies related to testing, such as pytest, coverage, faker, and their associated plugins (pytest-cov, pytest-mock, pytest-asyncio, pytest-click, pytest-xdist), have been updated or added to poetry.lock and pyproject.toml. This ensures a modern and robust testing environment.
  • Pytest and Coverage Configuration: Detailed configurations for Pytest and Coverage tools have been introduced in pyproject.toml. This includes defining test paths, adding strict markers and configuration options, setting up comprehensive coverage reporting (terminal, HTML, XML), enforcing a minimum coverage threshold of 85%, and configuring asyncio_mode.
  • CLI Output Refinement: The CLI output for test run executions has been streamlined. The dedicated 'Error' column has been removed from the display, with error states now implicitly communicated through the 'State' column. This change is reflected in the th_cli/commands/test_run_execution.py file and corresponding unit tests.
  • API Client Mocking Improvement: The mock_api_client fixture in tests/conftest.py has been enhanced to correctly mock the _async_client attribute of the ApiClient. This resolves potential issues where the API client's asynchronous behavior was not fully simulated during testing.
  • TestRunExecution Model Update: An error field of type Optional[str] has been added to the TestRunExecution model in th_cli/api_lib_autogen/models.py. While the CLI display no longer shows a dedicated error column, this update ensures the model accurately reflects potential error information from the API.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully fixes the CLI unit tests by adding and configuring testing dependencies like pytest and coverage. The changes also include a refactoring of the test_run_execution command to remove the 'Error' column from the table view, which simplifies the output. The tests have been updated to align with this change. Overall, the changes are solid and achieve the goal of getting the test suite back in working order. I have one suggestion to improve the table formatting for better alignment.

rquidute and others added 2 commits December 15, 2025 15:01
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@rquidute rquidute changed the title Fix/828 fix cli unit tests not working Fix cli unit tests not working Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants