-
Notifications
You must be signed in to change notification settings - Fork 4
Fix cli unit tests not working #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2.15-cli-develop
Are you sure you want to change the base?
Fix cli unit tests not working #50
Conversation
Summary of ChangesHello @rquidute, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on rectifying issues that prevented the CLI unit tests from executing correctly. It involves a significant overhaul of the Python testing dependency stack, establishing a comprehensive Pytest and Coverage configuration, and refining the display of test execution results within the command-line interface. These changes collectively aim to restore the functionality and reliability of the CLI's test suite. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully fixes the CLI unit tests by adding and configuring testing dependencies like pytest and coverage. The changes also include a refactoring of the test_run_execution command to remove the 'Error' column from the table view, which simplifies the output. The tests have been updated to align with this change. Overall, the changes are solid and achieve the goal of getting the test suite back in working order. I have one suggestion to improve the table formatting for better alignment.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Fix unit tests not working
Related Issue
project-chip/certification-tool#828
Testing
CLI Unit tests running successfully
