Skip to content

Conversation

@Amansingh0807
Copy link
Contributor

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • add constants/float16/eulergamma

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • Resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 12, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 12, 2025

Coverage Report

Package Statements Branches Functions Lines
constants/float16/eulergamma $\color{green}49/49$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}0/0$
$\color{green}+0.00%$
$\color{green}49/49$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit should be reverted. We want these sections to be present, and we do not use inline links but link definitions.

Otherwise, the PR looks good to me at first glance! Thanks!

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 13, 2025
@Amansingh0807
Copy link
Contributor Author

Thank you for the feedback @Planeshifter!

I apologize for the confusion - I had seen a message on Gitter mentioning that the "related" and "links" sections should be removed for new float16 constant PRs, so I attempted to follow that guidance.

I've now reverted those commits and restored the original structure.
The changes have been pushed.

Thanks again for reviewing!

@Planeshifter
Copy link
Member

@Amansingh0807 Thank you!

What @Neerajpathak07 meant to refer to, I am sure, is that the content inside of the <section class="related"> section is auto-populated, so they should be empty in any PR. Similarly, the links inside <!-- <related-links> --> <!-- </related-links> --> of the links section is auto-populated, as well. @Neerajpathak07, it would be good to clarify your message on Gitter, as otherwise I would expect more contributors remove the sections altogether.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 13, 2025
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Dec 13, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `constants/float16/eulergamma`

PR-URL: https://github.com/stdlib-js/stdlib/pull/9002

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 4061bd8 into stdlib-js:develop Dec 13, 2025
30 checks passed
@Neerajpathak07
Copy link
Member

@Planeshifter yeah I'll have to specify it even more. I'll just add the code block which is to be removed.

@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants